feat: Added Unsplash plugin sample #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Pablo Klaschka <pklaschka@users.noreply.github.com>
Co-authored-by: Pablo Klaschka <pklaschka@users.noreply.github.com>
Co-authored-by: Pablo Klaschka <pklaschka@users.noreply.github.com>
pklaschka
suggested changes
Feb 10, 2022
There was a problem hiding this comment.
Review: overall
- 🟢 Overall plugin structure looks awesome!
Review: server
Following README.md instructions:
- 🟢
npm installran successfully - 🟢 Copying
.env.sampleto.env - 🔴 Change Request:
.env.samplestill contains wrongly namedACCESS_KEY, should beUNSPLASH_ACCESS_KEY - 🟡 Minor Change Request:
PORTshould have a default value (both in theREADME.mdand.env.sample. I.e.,PORT=8000 - 🟢 Run
npm start=> server appears to be running successfully
Review plugin
Following README.md instructions:
- 🟢 Run
npm install=> success - 🟢 Copy
.env.sampleto.env - 🔴 Change Request: Document what the
API_BASE_URLshould be. I assumehttp://localhost:8000for the remaining review (as this is where the NodeJS server is running) - 🟡 Minor Change Request: Include a default value for this in both
.env.sampleandREADME.md, i.e.,API_BASE_URL=http://localhost:8000 - 🟢 Run
npm run build=> success - 🟢 Use UDT to load the plugin in Photoshop
Functional plugin test
The plugin runs without problems, functionality works as specified. This was what I came up with 😉 :
Conclusion
Overall, this looks great! Two small change requests, but after those are done, we can merge this 🎉 . Thanks again!
|
@pklaschka Done! Made these changes 🚀 🥳 |
pklaschka
approved these changes
Feb 10, 2022
There was a problem hiding this comment.
LGTM. Thank you for your contribution 🎉 🙂
(leaving this open for another 24 hours in case @amandahuarng or @kerrishotts want to take a look and I'll merge it afterwards)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes issue #46.
What does it do?
This is a plugin sample for Photoshop which lets you search for Unsplash images and display the top 10 results in a grid form inside the plugin window. Then you can click on the download button and save those images to your system.
How to run the project?
Please refer to the README in the project for more information.
Sample Preview
Check out the sample preview here